kkhatua commented on a change in pull request #1742: DRILL-7160: e.q.max_rows
QUERY-level option shown even if not set
URL: https://github.com/apache/drill/pull/1742#discussion_r273966816
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/server/rest/profile/ProfileWrapper.java
##########
@@ -336,7 +336,8 @@ public String getOperatorsJSON() {
}
public Map<String, String> getQueryOptions() {
- return getOptions(o -> OptionValue.OptionScope.QUERY == o.getScope());
+ // Skip reporting QUERY_MAX_ROWS if it is inapplicable and set to zero
(e.g. query -> SHOW FILES)
+ return getOptions(o -> OptionValue.OptionScope.QUERY == o.getScope() &&
!(ExecConstants.QUERY_MAX_ROWS.equals(o.getName()) &&
String.valueOf(o.getValue()).equals("0")));
Review comment:
This change actually helps to not show the value of Zero being applied, when
the query is inapplicable. Are you sure we want to remove this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
