kkhatua commented on a change in pull request #1742: DRILL-7160: e.q.max_rows 
QUERY-level option shown even if not set
URL: https://github.com/apache/drill/pull/1742#discussion_r273972484
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/planner/sql/DrillSqlWorker.java
 ##########
 @@ -226,7 +226,10 @@ private static SqlNode 
checkAndApplyAutoLimit(SqlConverter parser, QueryContext
     if (isAutoLimitShouldBeApplied(context, sqlNode)) {
       sqlNode = wrapWithAutoLimit(sqlNode, context);
     } else {
-      context.getOptions().setLocalOption(ExecConstants.QUERY_MAX_ROWS, 0);
+        //Force setting to zero IFF autoLimit was intended to be set 
originally but is inapplicable
 
 Review comment:
   👍 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to