amansinha100 commented on a change in pull request #1752: DRILL-7182: Incorrect
access specifier for Join DrillRelMdDistinctRowcount
URL: https://github.com/apache/drill/pull/1752#discussion_r276099883
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdDistinctRowCount.java
##########
@@ -174,7 +174,7 @@ private Double getDistinctRowCount(DrillScanRelBase scan,
RelMetadataQuery mq, D
}
}
- public Double getDistinctRowCount(DrillJoinRelBase joinRel, RelMetadataQuery
mq, ImmutableBitSet groupKey,
+ private Double getDistinctRowCount(DrillJoinRelBase joinRel,
RelMetadataQuery mq, ImmutableBitSet groupKey,
Review comment:
Wouldn't it be better to rename this (and the other private methods here)
with an 'internal' suffix to avoid potential issues in the future ? Only the
Override methods remain unchanged. What do you think ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
