vvysotskyi commented on a change in pull request #1752: DRILL-7182: Incorrect
access specifier for Join DrillRelMdDistinctRowcount
URL: https://github.com/apache/drill/pull/1752#discussion_r276128478
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/cost/DrillRelMdDistinctRowCount.java
##########
@@ -92,7 +92,7 @@ public Double getDistinctRowCount(RelNode rel,
RelMetadataQuery mq, ImmutableBit
if (rel instanceof DrillScanRel) {
// The existing Drill behavior is to only use this estimation for
DrillScanRel and not ScanPrel.
// TODO: We may potentially do it for ScanPrel (outside the scope of
statistics)
- return rel.estimateRowCount(mq) * 0.1;
+ return ((DrillScanRel)rel).estimateRowCount(mq) * 0.1;
Review comment:
This cast is not needed, please revert this change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services