Sure. I will do it. Thanks, Sorabh
On Fri, Apr 26, 2019 at 8:35 AM Arina Yelchiyeva <arina.yelchiy...@gmail.com> wrote: > Sure, we can discuss it during Hangout. > Sorabh, since you are latest release manager, I am wondering if you would > volunteer to add scripts into Drill project? :) > At least something to start with. > > Kind regards, > Arina > > > On Apr 26, 2019, at 6:32 PM, SorabhApache <sor...@apache.org> wrote: > > > > +1 for including release scripts. I would also recommend adding a > README.md > > in the same location, which can include link to a wiki for the release > > process or all the instructions in it. Also it would be great if we can > > formulate some guidelines as to what kind of issues may not be considered > > as blocker for a release going forward. May be we can discuss in the next > > hangout as well. > > > > Thanks, > > Sorabh > > > > On Fri, Apr 26, 2019 at 8:03 AM Aman Sinha <amansi...@gmail.com> wrote: > > > >> +1 on including the release preparation script into the code base. > Location > >> TBD. Perhaps under a separate 'release' subdirectory either in contrib > or > >> docs ? > >> > >> On Fri, Apr 26, 2019 at 12:46 AM Arina Yelchiyeva < > >> arina.yelchiy...@gmail.com> wrote: > >> > >>> Maybe we should include these scripts directly into Drill project (of > >>> course if Parth does not mind), maybe in doc module? > >>> This way we will be able to modify them if needed using regular PR > >> process > >>> and everybody will know where to find them. > >>> > >>> Any thoughts? > >>> > >>> Kind regards, > >>> Arina > >>> > >>>> On Apr 26, 2019, at 1:56 AM, SorabhApache <sor...@apache.org> wrote: > >>>> > >>>> Update: > >>>> DRILL-7201 / DRILL-7202: Kunal has fixes for both and are > >>> ready-to-commit. > >>>> DRILL-7213: drill-format-mapr.jar contains stale git.properties file > >>>> > >>>> - The main issue here was that in 1.14 and 1.15 drill-format-mapr.jar > >>>> was included with release tarballs where it shouldn't be. So Vova > >>> helped to > >>>> make a change in 1.16 to fix that and now format-mapr will not be > >>> included > >>>> in release tarballs, not any mapr specific jars. The PR is approved > >> and > >>>> ready-to-commit. > >>>> > >>>> DRILL-7212: Add gpg key with apache.org email for sorabh > >>>> > >>>> - PR is opened for it. I have added both my emails to the gpg key and > >>> is > >>>> signed by boaz. > >>>> > >>>> DRILL-7207: Update the copyright year in NOTICE.txt file > >>>> > >>>> - PR is opened for this as well. > >>>> > >>>> Last issue which Vova reported about files like > >>>> > >>> > >> > *org.codehaus.plexus.compiler.javac.JavacCompiler1256088670033285178arguments* > >>>> being included in jar. This was present in 1.14 as well but not in > >> 1.15. > >>>> The reason is it looks like different processes are followed for > >> release. > >>>> Every release done using the script (drill-release.sh)[1] will have > >> above > >>>> file. The reason is because the *mvn release:prepare* phase is done > >> with > >>> -X > >>>> flag which creates debug files and those are not excluded from > >> maven-jar > >>>> plugin configuration. After removing the -X option I am not seeing > >> above > >>>> files anymore and speed of prepare phase is increased significantly as > >>>> well. Will submit a separate PR for this change in script post > release. > >>>> > >>>> Once all the changes are merged into master, I will re-prepare the RC > >>>> candidate and share with the community. > >>>> > >>>> [1]: https://github.com/parthchandra/stuff/tree/master/scripts > >>>> > >>>> Thanks, > >>>> Sorabh > >>>> > >>>> On Thu, Apr 25, 2019 at 3:02 PM Kunal Khatua <ku...@apache.org> > wrote: > >>>> > >>>>> UPDATE: > >>>>> > >>>>> > >>>>> Both, DRILL-7201 and DRILL-7202 has been fixed and verified by Sorabh > >>>>> and Arina, so we can have it as part of "RC2". > >>>>> > >>>>> (Thanks for catching the issues, Arina ! ) > >>>>> > >>>>> ~ kunal > >>>>> > >>>>> On 4/25/2019 4:12:16 AM, Volodymyr Vysotskyi <volody...@apache.org> > >>> wrote: > >>>>> Hi Sorabh, > >>>>> > >>>>> I have noticed that jars in prebuild tar contain some strange files, > >> for > >>>>> example, *drill-jdbc-all-1.16.0.jar* contains the following files: > >>>>> *javac.sh* > >>>>> > >>>>> > >>> > >> > *org.codehaus.plexus.compiler.javac.JavacCompiler1256088670033285178arguments* > >>>>> > >>>>> > >>> > >> > *org.codehaus.plexus.compiler.javac.JavacCompiler1458111453480208588arguments* > >>>>> > >>>>> > >>> > >> > *org.codehaus.plexus.compiler.javac.JavacCompiler2392560589194600493arguments* > >>>>> > >>>>> > >>> > >> > *org.codehaus.plexus.compiler.javac.JavacCompiler4475905192586529595arguments* > >>>>> > >>>>> > >>> > >> > *org.codehaus.plexus.compiler.javac.JavacCompiler4524532450095901144arguments* > >>>>> > >>>>> > >>> > >> > *org.codehaus.plexus.compiler.javac.JavacCompiler4670895443631397937arguments* > >>>>> > >>>>> > >>> > >> > *org.codehaus.plexus.compiler.javac.JavacCompiler5215058338087807885arguments* > >>>>> > >>>>> > >>> > >> > *org.codehaus.plexus.compiler.javac.JavacCompiler7526103232425779297arguments* > >>>>> > >>>>> which contain some info about your machine (username, etc.) > >>>>> > >>>>> Jars from the previous release didn't contain these files. Also, I > >> have > >>>>> built master on my machine and these files are absent for me. > >>>>> > >>>>> Could you please take a look? This problem is observed for both RCs. > >>>>> > >>>>> Kind regards, > >>>>> Volodymyr Vysotskyi > >>>>> > >>>>> > >>>>> On Thu, Apr 25, 2019 at 8:20 AM SorabhApache wrote: > >>>>> > >>>>>> Update: > >>>>>> 1) DRILL-7208 is there in 1.15 release as well, so it's not a > blocker > >>> for > >>>>>> 1.16 > >>>>>> 2) DRILL-7213: drill-format-mapr.jar contains stale git.properties > >> file > >>>>>> > >>>>>> - Still investigating on the above issue. > >>>>>> > >>>>>> 3) DRILL-7201: Strange symbols in error window (Windows) > >>>>>> > >>>>>> - Issue is not reproducible on Kunal's machine. He is having > >> discussion > >>>>>> on JIRA to see if it's treated as a blocker or not. > >>>>>> > >>>>>> To investigate for DRILL-7213 I have to drop the RC1 candidate since > >>>>> again > >>>>>> performing the release required to push it to my remote repo and > >>> publish > >>>>> to > >>>>>> maven repo as well. So I don't have RC1 binaries if we consider all > >> the > >>>>>> issues as non-blocking. > >>>>>> > >>>>>> I will re-share the RC candidate once either fix for > >>>>> DRILL-7213/DRILL-7201 > >>>>>> are available or it's considered as non-blockers. Any thoughts? > >>>>>> > >>>>>> Thanks, > >>>>>> Sorabh > >>>>>> > >>>>>> On Wed, Apr 24, 2019 at 9:17 PM Boaz Ben-Zvi wrote: > >>>>>> > >>>>>>> Downloaded both the binary and src tarballs, and verified the SHA > >>>>>>> signatures and the PGP. > >>>>>>> > >>>>>>> Built and ran the full unit tests on both Linux and Mac (took 3:05 > >>>>> hours > >>>>>>> on my Mac). > >>>>>>> > >>>>>>> Successfully ran some old favorite queries with > >>> Sort/Hash-Join/Hash-Agg > >>>>>>> spilling. > >>>>>>> > >>>>>>> Ran several manual tests of REFRESH METADATA with COLUMNS, and > >>> verified > >>>>>>> the metadata files and summaries. > >>>>>>> > >>>>>>> Noticed that when specifying a COLUMN which a sub-field in a > complex > >>>>>>> type (e.g., a key in a map), the whole column (i.e. all the other > >> keys > >>>>>>> as well) was marked as "interesting"; but this may be "by design", > >> as > >>>>>>> the refresh granularity is the whole column. > >>>>>>> > >>>>>>> Also noticed the sys.version issue (DRILL-7208 > >>>>>>> ) - should be minor as > >>>>>>> only affecting users of the SRC tarball, likely developers who > >>>>>>> build/modify the code anyway. > >>>>>>> > >>>>>>> Hence my vote is +1 . > >>>>>>> > >>>>>>> -- Boaz > >>>>>>> > >>>>>>> On 4/24/19 10:57 AM, Kunal Khatua wrote: > >>>>>>>> Downloaded the tarball and tried it in embedded mode. > >>>>>>>> > >>>>>>>> Ran simple join queries and interacted with the WebUI. > >>>>>>>> > >>>>>>>> Issues confirmed were DRILL-7192 and DRILL-7203. > >>>>>>>> I'm unable to repro DRILL-7201 and DRILL-7202, though I have a fix > >>>>> for > >>>>>>> the latter. Will work with Arina to identify repro steps. > >>>>>>>> > >>>>>>>> None of these are blockers IMO, so I'll vote +1. > >>>>>>>> > >>>>>>>> ~ Kunal > >>>>>>>> > >>>>>>>> > >>>>>>>> On 4/24/2019 10:38:31 AM, Khurram Faraaz wrote: > >>>>>>>> i see the correct version and commit, I deployed the binaries to > >>>>> test. > >>>>>>>> > >>>>>>>> Apache Drill 1.16.0 > >>>>>>>> "Start your SQL engine." > >>>>>>>> apache drill> select * from sys.version; > >>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+------------------------------------------+-----------------------------------------------------+---------------------------+-------------------+---------------------------+ > >>>>>>>> | version | commit_id | > >>>>>>>> commit_message | commit_time | > >>>>>>>> build_email | build_time | > >>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+------------------------------------------+-----------------------------------------------------+---------------------------+-------------------+---------------------------+ > >>>>>>>> | 1.16.0 | cf5b758e0a4c22b75bfb02ac2653ff09415ddf53 | > >>>>>>>> [maven-release-plugin] prepare release drill-1.16.0 | 22.04.2019 @ > >>>>>>> 09:08:36 > >>>>>>>> PDT | sor...@apache.org | 22.04.2019 @ 09:53:25 PDT | > >>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+------------------------------------------+-----------------------------------------------------+---------------------------+-------------------+---------------------------+ > >>>>>>>> 1 row selected (0.274 seconds) > >>>>>>>> apache drill> > >>>>>>>> > >>>>>>>> Thanks, > >>>>>>>> Khurram > >>>>>>>> > >>>>>>>> On Wed, Apr 24, 2019 at 9:52 AM SorabhApache wrote: > >>>>>>>> > >>>>>>>>> Hi Volodymyr/Anton, > >>>>>>>>> I can verify that I am seeing both the below issues as reported > by > >>>>>> Anton > >>>>>>>>> and Volodymyr. I will investigate further why we are seeing these > >>>>>>> issues. > >>>>>>>>> Thanks for catching this. Can you please open JIRA's for these > >>>>> issues > >>>>>> ? > >>>>>>>>> > >>>>>>>>> 1) Wrong result for sys.version query when built from source > >>>>> tarball. > >>>>>>>>> 2) git.properties file in drill-format-mapr-1.16.0.jar has wrong > >>>>>> commit > >>>>>>> id > >>>>>>>>> but as Volodymyr mentioned because of order in which jars are > >> picked > >>>>>> up > >>>>>>>>> it's not showing the issue when tried from prebuilt tarball. > >>>>>>>>> > >>>>>>>>> @Volodymyr Vysotskyi > >>>>>>>>> Regarding the GPG key I am not sure if we mandate it to use > >>>>>> apache.org, > >>>>>>>>> there other keys in the file which are using gmail address as > >> well. > >>>>> As > >>>>>>> far > >>>>>>>>> as the signing person is authenticating the key and details > >>>>> associated > >>>>>>> with > >>>>>>>>> it, I think it should be fine. But since it's recommended I will > >> use > >>>>>>>>> apache.org email address instead. > >>>>>>>>> > >>>>>>>>> Thanks, > >>>>>>>>> Sorabh > >>>>>>>>> > >>>>>>>>> On Wed, Apr 24, 2019 at 8:53 AM Volodymyr Vysotskyi > >>>>>>>>> wrote: > >>>>>>>>> > >>>>>>>>>> Hi Aman, > >>>>>>>>>> > >>>>>>>>>> There are two different issues connected with *git.properties* > >>>>> file. > >>>>>>>>>> Regarding the problem I have mentioned, prebuilt tar > >>>>>>>>>> (apache-drill-1.16.0.tar.gz) contains > >>>>> *drill-format-mapr-1.16.0.jar* > >>>>>>> jar > >>>>>>>>>> which contains a *git.properties* file with the incorrect > >> version. > >>>>>>>>>> When *select * from sys.version* query is submitted, class > loader > >>>>>> finds > >>>>>>>>> the > >>>>>>>>>> first file named as *git.properties* from the classpath (each > >> drill > >>>>>> jar > >>>>>>>>>> contains its own *git.properties* file) and for my case file > from > >>>>>>>>>> *drill-format-mapr-1.16.0.jar *is picked up, so the incorrect > >>>>> result > >>>>>> is > >>>>>>>>>> returned. But it may not be reproducible for other machines > since > >>>>> it > >>>>>>>>>> depends on the order of files for the class loader. > >>>>>>>>>> > >>>>>>>>>> Regarding the problem Anton has mentioned, Drill should be built > >>>>> from > >>>>>>> the > >>>>>>>>>> sources (apache-drill-1.16.0-src.tar.gz), and for that version, > >>>>>>> *select * > >>>>>>>>>> from sys.version* returns the result without information about > >>>>>> commit. > >>>>>>>>>> > >>>>>>>>>> Kind regards, > >>>>>>>>>> Volodymyr Vysotskyi > >>>>>>>>>> > >>>>>>>>>> > >>>>>>>>>> On Wed, Apr 24, 2019 at 6:33 PM Aman Sinha wrote: > >>>>>>>>>> > >>>>>>>>>>> This works fine for me with the binary tarball that I installed > >> on > >>>>>> my > >>>>>>>>>> Mac. > >>>>>>>>>>> ..it shows the correct commit message. > >>>>>>>>>>> > >>>>>>>>>>> Apache Drill 1.16.0 > >>>>>>>>>>> > >>>>>>>>>>> "This isn't your grandfather's SQL." > >>>>>>>>>>> > >>>>>>>>>>> apache drill> *select* * *from* sys.version; > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+------------------------------------------+-----------------------------------------------------+---------------------------+-------------------+---------------------------+ > >>>>>>>>>>> | version | commit_id | > >>>>>>>>>>> commit_message | commit_time | > >>>>>>>>>>> build_email | build_time | > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+------------------------------------------+-----------------------------------------------------+---------------------------+-------------------+---------------------------+ > >>>>>>>>>>> | 1.16.0 | cf5b758e0a4c22b75bfb02ac2653ff09415ddf53 | > >>>>>>>>>>> [maven-release-plugin] prepare release drill-1.16.0 | > >> 22.04.2019 @ > >>>>>>>>>> 09:08:36 > >>>>>>>>>>> PDT | sor...@apache.org | 22.04.2019 @ 09:54:09 PDT | > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+------------------------------------------+-----------------------------------------------------+---------------------------+-------------------+---------------------------+ > >>>>>>>>>>> I don't see any extraneous git.properties anywhere in the > source > >>>>>>>>>>> distribution that I downloaded: > >>>>>>>>>>> > >>>>>>>>>>> [root@aman1 apache-drill-1.16.0-src]# find . -name > >>>>> "git.properties" > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > ./distribution/target/apache-drill-1.16.0/apache-drill-1.16.0/git.properties > >>>>>>>>>>> ./git.properties > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> > >>>>>>>>>>> On Wed, Apr 24, 2019 at 4:51 AM Arina Ielchiieva > >>>>>>>>>> wrote: > >>>>>>>>>>>> Taking into account previous emails, looks like we'll need to > >>>>> have > >>>>>>>>> new > >>>>>>>>>>> RC. > >>>>>>>>>>>> I also suggest to include > >>>>>>>>>>> https://issues.apache.org/jira/browse/DRILL-7201 > >>>>>>>>>>>> into > >>>>>>>>>>>> new RC. > >>>>>>>>>>>> > >>>>>>>>>>>> Kind regards, > >>>>>>>>>>>> Arina > >>>>>>>>>>>> > >>>>>>>>>>>> On Wed, Apr 24, 2019 at 2:44 PM Volodymyr Vysotskyi <> > >>>>>>>>>>> volody...@apache.org> > >>>>>>>>>>>> wrote: > >>>>>>>>>>>> > >>>>>>>>>>>>> Also, I have noticed that for the prebuilt tar, the following > >>>>>> query > >>>>>>>>>> on > >>>>>>>>>>> my > >>>>>>>>>>>>> machine returns the wrong results: > >>>>>>>>>>>>> > >>>>>>>>>>>>> apache drill> select * from sys.version; > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+------------------------------------------+----------------------------------------------------------------+---------------------------+-------------------+---------------------------+ > >>>>>>>>>>>>> | version | commit_id | > >>>>>>>>>>>>> commit_message | commit_time > >>>>>>>>>> | > >>>>>>>>>>>>> build_email | build_time | > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+------------------------------------------+----------------------------------------------------------------+---------------------------+-------------------+---------------------------+ > >>>>>>>>>>>>> | 1.16.0 | b3db1ff4b0d29210593c4485125578cca7a64b42 | > >>>>> DRILL-7188: > >>>>>>>>>>> Revert > >>>>>>>>>>>>> DRILL-6642: Update protocol-buffers version | 21.04.2019 @ > >>>>>> 15:35:28 > >>>>>>>>>>> PDT | > >>>>>>>>>>>>> sor...@apache.org | 22.04.2019 @ 09:07:35 PDT | > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+------------------------------------------+----------------------------------------------------------------+---------------------------+-------------------+---------------------------+ > >>>>>>>>>>>>> 1 row selected (1.318 seconds) > >>>>>>>>>>>>> > >>>>>>>>>>>>> The root cause for this problem is that > >>>>>>>>> drill-format-mapr-1.16.0.jar > >>>>>>>>>>> jar > >>>>>>>>>>>>> contains git.properties file with incorrect version, and this > >>>>> file > >>>>>>>>>> was > >>>>>>>>>>>> the > >>>>>>>>>>>>> first one which was found by the class loader. > >>>>>>>>>>>>> > >>>>>>>>>>>>> I think this is a blocker for the release. > >>>>>>>>>>>>> > >>>>>>>>>>>>> Kind regards, > >>>>>>>>>>>>> Volodymyr Vysotskyi > >>>>>>>>>>>>> > >>>>>>>>>>>>> > >>>>>>>>>>>>> On Wed, Apr 24, 2019 at 2:31 PM Anton Gozhiy > >>>>>>>>>>>> wrote: > >>>>>>>>>>>>>> Clarification to my last message: > >>>>>>>>>>>>>> I downloaded Drill from here: > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > http://home.apache.org/~sorabh/drill/releases/1.16.0/rc1/apache-drill-1.16.0-src.tar.gz > >>>>>>>>>>>>>> and built it by command: > >>>>>>>>>>>>>> mvn clean install -DskipTests > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> On Wed, Apr 24, 2019 at 1:53 PM Anton Gozhiy <> > >>>>>>>>> anton5...@gmail.com> > >>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>> Hi All, > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> I found an issue with Drill version, used the provided rc1 > >>>>>>>>>> source: > >>>>>>>>>>>>>>> apache drill> select * from sys.version; > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+-----------+----------------+-------------+-------------+------------+ > >>>>>>>>>>>>>>> | version | commit_id | commit_message | commit_time | > >>>>>>>>>> build_email > >>>>>>>>>>> | > >>>>>>>>>>>>>>> build_time | > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+-----------+----------------+-------------+-------------+------------+ > >>>>>>>>>>>>>>> | 1.16.0 | Unknown | | | Unknown > >>>>>>>>>>> | > >>>>>>>>>>>>>>> | > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > +---------+-----------+----------------+-------------+-------------+------------+ > >>>>>>>>>>>>>>> Although there is a valid git.properties file in the Drill > >>>>> root > >>>>>>>>>>>>>> directory: > >>>>>>>>>>>>>>> #Generated by Git-Commit-Id-Plugin > >>>>>>>>>>>>>>> #Mon Apr 22 09:52:07 PDT 2019 > >>>>>>>>>>>>>>> git.branch=cf5b758e0a4c22b75bfb02ac2653ff09415ddf53 > >>>>>>>>>>>>>>> git.build.host=SHamirw-E755.local > >>>>>>>>>>>>>>> git.build.time=22.04.2019 @ 09\:52\:07 PDT > >>>>>>>>>>>>>>> git.build.user.email=sor...@apache.org > >>>>>>>>>>>>>>> git.build.user.name=Sorabh Hamirwasia > >>>>>>>>>>>>>>> git.build.version=1.16.0 > >>>>>>>>>>>>>>> git.closest.tag.commit.count=0 > >>>>>>>>>>>>>>> git.closest.tag.name=drill-1.16.0 > >>>>>>>>>>>>>>> git.commit.id=cf5b758e0a4c22b75bfb02ac2653ff09415ddf53 > >>>>>>>>>>>>>>> git.commit.id.abbrev=cf5b758 > >>>>>>>>>>>>>>> git.commit.id.describe=drill-1.16.0-0-gcf5b758 > >>>>>>>>>>>>>>> git.commit.id.describe-short=drill-1.16.0-0 > >>>>>>>>>>>>>>> git.commit.message.full=[maven-release-plugin] prepare > >> release > >>>>>>>>>>>>>> drill-1.16.0 > >>>>>>>>>>>>>>> git.commit.message.short=[maven-release-plugin] prepare > >>>>> release > >>>>>>>>>>>>>>> drill-1.16.0 > >>>>>>>>>>>>>>> git.commit.time=22.04.2019 @ 09\:08\:36 PDT > >>>>>>>>>>>>>>> git.commit.user.email=sor...@apache.org > >>>>>>>>>>>>>>> git.commit.user.name=Sorabh Hamirwasia > >>>>>>>>>>>>>>> git.dirty=false > >>>>>>>>>>>>>>> git.remote.origin.url=https\://github.com/apache/drill.git > >>>>>>>>>>>>>>> git.tags=drill-1.16.0 > >>>>>>>>>>>>>>> git.total.commit.count=3568 > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> But looks like it doesn't get into the classpath. > >>>>>>>>>>>>>>> Could someone take a look into this? > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> Thanks! > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> On Wed, Apr 24, 2019 at 11:50 AM Volodymyr Vysotskyi <> > >>>>>>>>>>>>>> volody...@apache.org> > >>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Hi Sorabh, > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Sorry for being picky, but looks like the key you have > >>>>>>>>> published > >>>>>>>>>>> was > >>>>>>>>>>>>>>>> generated for non-apache email: sohami.apa...@gmail.com. > >>>>>>>>>>> According > >>>>>>>>>>>> to > >>>>>>>>>>>>>> the > >>>>>>>>>>>>>>>> [1], it is highly recommended to use Apache email address > >> as > >>>>>>>>> the > >>>>>>>>>>>>> primary > >>>>>>>>>>>>>>>> User-ID. > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> [1] https://www.apache.org/dev/release-signing#user-id > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> Kind regards, > >>>>>>>>>>>>>>>> Volodymyr Vysotskyi > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>> On Wed, Apr 24, 2019 at 10:10 AM Jyothsna Reddy <> > >>>>>>>>>>>>> jyothsna....@gmail.com > >>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> Built it from cloning the git branch and unit tests on my > >>>>>>>>>> Linux > >>>>>>>>>>> VM > >>>>>>>>>>>>>> (time > >>>>>>>>>>>>>>>>> taken - 43 min). > >>>>>>>>>>>>>>>>> Tested new features of metadata caching by creating v4 > >> cache > >>>>>>>>>>> files > >>>>>>>>>>>>>> using > >>>>>>>>>>>>>>>>> new Refresh Metadata commands and manually verified the > >>>>>>>>> cache > >>>>>>>>>>>> files. > >>>>>>>>>>>>>>>> Tried > >>>>>>>>>>>>>>>>> a few queries that use metadata cache and verified > >> results. > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> The release looks good to me +1. > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> Thank you, > >>>>>>>>>>>>>>>>> Jyothsna > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> [image: Mailtrack] > >>>>>>>>>>>>>>>>> <> > >>>>>>>>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&; > >>>>>>>>>>>>>>>>> Sender > >>>>>>>>>>>>>>>>> notified by > >>>>>>>>>>>>>>>>> Mailtrack > >>>>>>>>>>>>>>>>> <> > >>>>>>>>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://mailtrack.io?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality5&; > >>>>>>>>>>>>>>>>> 04/24/19, > >>>>>>>>>>>>>>>>> 12:09:52 AM > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>> On Wed, Apr 24, 2019 at 12:09 AM Jyothsna Reddy <> > >>>>>>>>>>>>>> jyothsna....@gmail.com > >>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> Built it from cloning the git branch and unit tests on > my > >>>>>>>>>>> Linux > >>>>>>>>>>>> VM > >>>>>>>>>>>>>>>> (time > >>>>>>>>>>>>>>>>>> taken - 43 min). > >>>>>>>>>>>>>>>>>> Tested new features of metadata caching by creating v4 > >>>>>>>>> cache > >>>>>>>>>>>> files > >>>>>>>>>>>>>>>> using > >>>>>>>>>>>>>>>>>> new Refresh Metadata commands and manually verified the > >>>>>>>>>> cache > >>>>>>>>>>>>> files. > >>>>>>>>>>>>>>>>> Tried > >>>>>>>>>>>>>>>>>> a few queries that use metadata cache and verified > >>>>>>>>> results. > >>>>>>>>>>>>>>>>>> Did a few manual tests with REFRESH METADATA by creating > >>>>>>>>> the > >>>>>>>>>>> new > >>>>>>>>>>>>> V4 > >>>>>>>>>>>>>>>>>> The release looks good to me +1. > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> Thank you, > >>>>>>>>>>>>>>>>>> Jyothsna > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>> On Tue, Apr 23, 2019 at 1:56 PM Sorabh Hamirwasia <> > >>>>>>>>>>>>>>>> shamirwa...@mapr.com> > >>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> Hi Volodymyr, > >>>>>>>>>>>>>>>>>>> The KEYS file on svn will be updated when a release > >>>>>>>>>> candidate > >>>>>>>>>>>> is > >>>>>>>>>>>>>>>>> approved > >>>>>>>>>>>>>>>>>>> and all the artifacts are copied to the svn. > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> NOTICE is not updated per release so I won't treat it > as > >>>>>>>>>>>> blocker. > >>>>>>>>>>>>>> But > >>>>>>>>>>>>>>>>>>> would > >>>>>>>>>>>>>>>>>>> be good to add it in the wiki below to ensure from next > >>>>>>>>>> time > >>>>>>>>>>>>>> onwards > >>>>>>>>>>>>>>>>> it's > >>>>>>>>>>>>>>>>>>> updated. > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> For release I am following this wiki[1] which is part > of > >>>>>>>>>>>> Parth's > >>>>>>>>>>>>>>>>>>> repository. I will update it to include both the steps > >>>>>>>>>> above > >>>>>>>>>>> as > >>>>>>>>>>>>>> well. > >>>>>>>>>>>>>>>>>>> [1]: > >>>>>>>>>> > https://github.com/parthchandra/drill/wiki/Drill-Release-Process > >>>>>>>>>>>>>>>>>>> Thanks, > >>>>>>>>>>>>>>>>>>> Sorabh > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>> On Tue, Apr 23, 2019 at 1:19 PM Volodymyr Vysotskyi <> > >>>>>>>>>>>>>>>>> volody...@apache.org > >>>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> Sorabh, could you please add your key to the > >>>>>>>>>>>>>>>>>>>> https://dist.apache.org/repos/dist/release/drill/KEYS > >>>>>>>>>>> file? > >>>>>>>>>>>>>>>>>>>> Not sure that it is a blocker, but the year in NOTICE > >>>>>>>>> is > >>>>>>>>>>>> 2018. > >>>>>>>>>>>>>>>>>>>> Do we have any guides for basic checks for release? If > >>>>>>>>>> no, > >>>>>>>>>>> it > >>>>>>>>>>>>>>>> would be > >>>>>>>>>>>>>>>>>>> good > >>>>>>>>>>>>>>>>>>>> to introduce such a list of things to check for the > >>>>>>>>>> release > >>>>>>>>>>>>>>>> manager. > >>>>>>>>>>>>>>>>>>>> Kind regards, > >>>>>>>>>>>>>>>>>>>> Volodymyr Vysotskyi > >>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>> On Tue, Apr 23, 2019 at 11:09 PM Aman Sinha <> > >>>>>>>>>>>>>> amansi...@apache.org> > >>>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>>>>> Downloaded source tarball on my Linux VM and built > >>>>>>>>> and > >>>>>>>>>>> ran > >>>>>>>>>>>>> unit > >>>>>>>>>>>>>>>>> tests > >>>>>>>>>>>>>>>>>>>>> successfully (elapsed time 46 mins). > >>>>>>>>>>>>>>>>>>>>> Downloaded binary tarball on my Mac and ran in > >>>>>>>>>> embedded > >>>>>>>>>>>>> mode. > >>>>>>>>>>>>>>>>>>>>> Verified Sorabh's release signature using gpg > >>>>>>>>> --verify > >>>>>>>>>>>>>>>>>>>>> Checked the maven artifacts are published > >>>>>>>>>>>>>>>>>>>>> Checked Ran a few queries against TPC-DS SF1 and > >>>>>>>>>> examined > >>>>>>>>>>>>> query > >>>>>>>>>>>>>>>>>>> profiles > >>>>>>>>>>>>>>>>>>>> in > >>>>>>>>>>>>>>>>>>>>> the Web UI. Looked good. > >>>>>>>>>>>>>>>>>>>>> Did a few manual tests with REFRESH METADATA by > >>>>>>>>>> creating > >>>>>>>>>>>> the > >>>>>>>>>>>>>> new > >>>>>>>>>>>>>>>> V4 > >>>>>>>>>>>>>>>>>>>>> metadata cache and checked EXPLAIN plans and query > >>>>>>>>>>> results. > >>>>>>>>>>>>>>>>>>>>> Found an issue with control-c handling and filed > >>>>>>>>>>> DRILL-7198 > >>>>>>>>>>>>>> and > >>>>>>>>>>>>>>>>>>> noted in > >>>>>>>>>>>>>>>>>>>>> the JIRA that I don't think it is a blocker. > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> Overall, release looks good ! +1 > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> Aman > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>> On Tue, Apr 23, 2019 at 10:01 AM SorabhApache <> > >>>>>>>>>>>>>> sor...@apache.org > >>>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>>>>>> Thanks Aman and Volodymyr for discussing on this > >>>>>>>>>> issue. > >>>>>>>>>>>>> Just > >>>>>>>>>>>>>> to > >>>>>>>>>>>>>>>>>>> clarify > >>>>>>>>>>>>>>>>>>>>> on > >>>>>>>>>>>>>>>>>>>>>> the thread that RC1 still stands as valid, since > >>>>>>>>> the > >>>>>>>>>>>> issue > >>>>>>>>>>>>> is > >>>>>>>>>>>>>>>> not > >>>>>>>>>>>>>>>>>>>> blocker > >>>>>>>>>>>>>>>>>>>>>> anymore. > >>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>> On Tue, Apr 23, 2019 at 9:18 AM Volodymyr > >>>>>>>>> Vysotskyi <> > >>>>>>>>>>>>>>>>>>>>> volody...@apache.org> > >>>>>>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>> Discussed with Aman and concluded that this issue > >>>>>>>>>> is > >>>>>>>>>>>> not > >>>>>>>>>>>>> a > >>>>>>>>>>>>>>>>> blocker > >>>>>>>>>>>>>>>>>>>> for > >>>>>>>>>>>>>>>>>>>>>> the > >>>>>>>>>>>>>>>>>>>>>>> release. > >>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>> Kind regards, > >>>>>>>>>>>>>>>>>>>>>>> Volodymyr Vysotskyi > >>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>> On Tue, Apr 23, 2019 at 6:39 PM Aman Sinha <> > >>>>>>>>>>>>>>>> amansi...@gmail.com > >>>>>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>>>>>>>> Hi Vova, > >>>>>>>>>>>>>>>>>>>>>>>> I added some thoughts in the DRILL-7195 JIRA. > >>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>> Aman > >>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>> On Tue, Apr 23, 2019 at 6:06 AM Volodymyr > >>>>>>>>>>> Vysotskyi <> > >>>>>>>>>>>>>>>>>>>>>>> volody...@apache.org> > >>>>>>>>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>>> Hi all, > >>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>>> I did some checks and found the following > >>>>>>>>>> issues: > >>>>>>>>>>>>>>>>>>>>>>>>> - DRILL-7195 <> > >>>>>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/DRILL-7195> > >>>>>>>>>>>>>>>>>>>>>>>>> - DRILL-7194 <> > >>>>>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/DRILL-7194> > >>>>>>>>>>>>>>>>>>>>>>>>> - DRILL-7192 <> > >>>>>>>>>>>>>>>>>>> https://issues.apache.org/jira/browse/DRILL-7192> > >>>>>>>>>>>>>>>>>>>>>>>>> One of them (DRILL-7194) is also reproduced > >>>>>>>>> on > >>>>>>>>>>> the > >>>>>>>>>>>>>>>> previous > >>>>>>>>>>>>>>>>>>>>> version, > >>>>>>>>>>>>>>>>>>>>>>>>> another is connected with the new feature > >>>>>>>>>>>>> (DRILL-7192), > >>>>>>>>>>>>>>>> so I > >>>>>>>>>>>>>>>>>>>> don't > >>>>>>>>>>>>>>>>>>>>>>> think > >>>>>>>>>>>>>>>>>>>>>>>>> that we should treat them as blockers. > >>>>>>>>>>>>>>>>>>>>>>>>> The third one (DRILL-7195) is a regression > >>>>>>>>> and > >>>>>>>>>> in > >>>>>>>>>>>>> some > >>>>>>>>>>>>>>>> cases > >>>>>>>>>>>>>>>>>>> may > >>>>>>>>>>>>>>>>>>>>>> cause > >>>>>>>>>>>>>>>>>>>>>>>> the > >>>>>>>>>>>>>>>>>>>>>>>>> wrong results, so I think that it should be > >>>>>>>>>> fixed > >>>>>>>>>>>>>> before > >>>>>>>>>>>>>>>> the > >>>>>>>>>>>>>>>>>>>>> release. > >>>>>>>>>>>>>>>>>>>>>>>>> Any thoughts? > >>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>>> Kind regards, > >>>>>>>>>>>>>>>>>>>>>>>>> Volodymyr Vysotskyi > >>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>>> On Mon, Apr 22, 2019 at 8:58 PM SorabhApache > >>>>>>>>> <> > >>>>>>>>>>>>>>>>>>> sor...@apache.org> > >>>>>>>>>>>>>>>>>>>>>>> wrote: > >>>>>>>>>>>>>>>>>>>>>>>>>> *< please="" disregard="" previous="" email,=""> > >>>>>> one="" > >>>>>>> of=""> > >>>>>>>>>> the > >>>>>>>>>>>> link > >>>>>>>>>>>>>> is > >>>>>>>>>>>>>>>> not > >>>>>>>>>>>>>>>>>>>>> correct > >>>>>>>>>>>>>>>>>>>>>> in > >>>>>>>>>>>>>>>>>>>>>>>> it. > >>>>>>>>>>>>>>>>>>>>>>>>>> Use the information in this email instead > >>>>>>>>>> * > >>>>>>>>>>>>>>>>>>>>>>>>>> Hi Drillers, > >>>>>>>>>>>>>>>>>>>>>>>>>> I'd like to propose the second release > >>>>>>>>>>> candidate > >>>>>>>>>>>>>> (RC1) > >>>>>>>>>>>>>>>> for > >>>>>>>>>>>>>>>>>>> the > >>>>>>>>>>>>>>>>>>>>>> Apache > >>>>>>>>>>>>>>>>>>>>>>>>>> Drill, > >>>>>>>>>>>>>>>>>>>>>>>>>> version 1.16.0. > >>>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>>>> Changes since the previous release > >>>>>>>>> candidate: > >>>>>>>>>>>>>>>>>>>>>>>>>> DRILL-7185: Drill Fails to Read Large > >>>>>>>>> Packets > >>>>>>>>>>>>>>>>>>>>>>>>>> DRILL-7186: Missing storage.json REST > >>>>>>>>>> endpoint > >>>>>>>>>>>>>>>>>>>>>>>>>> DRILL-7190: Missing backward compatibility > >>>>>>>>>> for > >>>>>>>>>>>> REST > >>>>>>>>>>>>>> API > >>>>>>>>>>>>>>>>> with > >>>>>>>>>>>>>>>>>>>>>>> DRILL-6562 > >>>>>>>>>>>>>>>>>>>>>>>>>> Also below 2 JIRA's were created to > >>>>>>>>>> separately > >>>>>>>>>>>>> track > >>>>>>>>>>>>>>>>> revert > >>>>>>>>>>>>>>>>>>> of > >>>>>>>>>>>>>>>>>>>>>>> protbuf > >>>>>>>>>>>>>>>>>>>>>>>>>> changes in 1.16.0: > >>>>>>>>>>>>>>>>>>>>>>>>>> DRILL-7188: Revert DRILL-6642: Update > >>>>>>>>>>>>>> protocol-buffers > >>>>>>>>>>>>>>>>>>> version > >>>>>>>>>>>>>>>>>>>>>>>>>> DRILL-7189: Revert DRILL-7105 Error while > >>>>>>>>>>>> building > >>>>>>>>>>>>>> the > >>>>>>>>>>>>>>>>> Drill > >>>>>>>>>>>>>>>>>>>>> native > >>>>>>>>>>>>>>>>>>>>>>>>> client > >>>>>>>>>>>>>>>>>>>>>>>>>> The RC1 includes total of 215 resolved > >>>>>>>>> JIRAs > >>>>>>>>>>> [1]. > >>>>>>>>>>>>>>>>>>>>>>>>>> Thanks to everyone for their hard work to > >>>>>>>>>>>>> contribute > >>>>>>>>>>>>>> to > >>>>>>>>>>>>>>>>> this > >>>>>>>>>>>>>>>>>>>>>> release. > >>>>>>>>>>>>>>>>>>>>>>>>>> The tarball artifacts are hosted at [2] and > >>>>>>>>>> the > >>>>>>>>>>>>> maven > >>>>>>>>>>>>>>>>>>> artifacts > >>>>>>>>>>>>>>>>>>>>> are > >>>>>>>>>>>>>>>>>>>>>>>>> hosted > >>>>>>>>>>>>>>>>>>>>>>>>>> at [3]. > >>>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>>>> This release candidate is based on commit > >>>>>>>>>>>>>>>>>>>>>>>>>> cf5b758e0a4c22b75bfb02ac2653ff09415ddf53 > >>>>>>>>>>> located > >>>>>>>>>>>> at > >>>>>>>>>>>>>>>> [4]. > >>>>>>>>>>>>>>>>>>>>>>>>>> Please download and try out the release > >>>>>>>>>>>> candidate. > >>>>>>>>>>>>>>>>>>>>>>>>>> The vote ends at 06:00 PM UTC (11:00 AM > >>>>>>>>> PDT, > >>>>>>>>>>>> 09:00 > >>>>>>>>>>>>> PM > >>>>>>>>>>>>>>>> EET, > >>>>>>>>>>>>>>>>>>>> 11:30 > >>>>>>>>>>>>>>>>>>>>> PM > >>>>>>>>>>>>>>>>>>>>>>>> IST), > >>>>>>>>>>>>>>>>>>>>>>>>>> Apr 25th, 2019 > >>>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>>>> [ ] +1 > >>>>>>>>>>>>>>>>>>>>>>>>>> [ ] +0 > >>>>>>>>>>>>>>>>>>>>>>>>>> [ ] -1 > >>>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>>>> Here is my vote: +1 > >>>>>>>>>>>>>>>>>>>>>>>>>> [1] > >>>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12313820&version=12344284 > >>>>>>>>>>>>>>>>>>>>>>>>>> [2] > >>>>>>>>>> http://home.apache.org/~sorabh/drill/releases/1.16.0/rc1/ > >>>>>>>>>>>>>>>>>>>>>>>>>> [3] > >>>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>> > >>>>>>> > >>>>> > >> https://repository.apache.org/content/repositories/orgapachedrill-1067/ > >>>>>>>>>>>>>>>>>>>>>>>>>> [4] > >>>>>>>>>>>>>>>>> https://github.com/sohami/drill/commits/drill-1.16.0 > >>>>>>>>>>>>>>>>>>>>>>>>>> Thanks, > >>>>>>>>>>>>>>>>>>>>>>>>>> Sorabh > >>>>>>>>>>>>>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>>> -- > >>>>>>>>>>>>>>> Sincerely, Anton Gozhiy > >>>>>>>>>>>>>>> anton5...@gmail.com > >>>>>>>>>>>>>>> > >>>>>>>>>>>>>> > >>>>>>>>>>>>>> -- > >>>>>>>>>>>>>> Sincerely, Anton Gozhiy > >>>>>>>>>>>>>> anton5...@gmail.com > >>>>>>>>>>>>>> > >>>>>>> > >>>>>> > >>>>> > >>> > >>> > >> > > >
