sohami commented on a change in pull request #1762: [DRILL-7191 / DRILL-7026]: RM state blob persistence in Zookeeper and Integration of Distributed queue configuration with Planner URL: https://github.com/apache/drill/pull/1762#discussion_r279985901
########## File path: exec/java-exec/src/main/java/org/apache/drill/common/DrillNode.java ########## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.common; + +import org.apache.drill.exec.proto.CoordinationProtos.DrillbitEndpoint; + +/** + * DrillNode encapsulates a drillendpoint. DrillbitEndpoint is a protobuf generated class which requires + * all the member variables to be equal for DrillbitEndpoints to be equal. DrillNode relaxes this requirement + * by only comparing required variables. + */ +public class DrillNode { + private final DrillbitEndpoint endpoint; + + public DrillNode(DrillbitEndpoint endpoint) { + this.endpoint = endpoint; + } + + public static DrillNode create(DrillbitEndpoint endpoint) { + return new DrillNode(endpoint); + } + + public boolean equals(Object other) { + if (!(other instanceof DrillNode)) { + return false; + } + + DrillbitEndpoint otherEndpoint = ((DrillNode) other).endpoint; + return endpoint.getAddress().equals(otherEndpoint.getAddress()) && + endpoint.getUserPort() == otherEndpoint.getUserPort() && + endpoint.getControlPort() == otherEndpoint.getControlPort() && + endpoint.getDataPort() == otherEndpoint.getDataPort() && + endpoint.getVersion().equals(otherEndpoint.getVersion()); + } + + @Override + public int hashCode() { + int hash = 41; + hash = (19 * hash) + endpoint.getDescriptor().hashCode(); + if (endpoint.hasAddress()) { + hash = (37 * hash) + endpoint.ADDRESS_FIELD_NUMBER; + hash = (53 * hash) + endpoint.getAddress().hashCode(); + } + if (endpoint.hasUserPort()) { + hash = (37 * hash) + endpoint.USER_PORT_FIELD_NUMBER; + hash = (53 * hash) + endpoint.getUserPort(); + } + if (endpoint.hasControlPort()) { + hash = (37 * hash) + endpoint.CONTROL_PORT_FIELD_NUMBER; + hash = (53 * hash) + endpoint.getControlPort(); + } + if (endpoint.hasDataPort()) { + hash = (37 * hash) + endpoint.DATA_PORT_FIELD_NUMBER; + hash = (53 * hash) + endpoint.getDataPort(); + } + if (endpoint.hasVersion()) { + hash = (37 * hash) + endpoint.VERSION_FIELD_NUMBER; + hash = (53 * hash) + endpoint.getVersion().hashCode(); + } + return hash; + } + + + @Override + public String toString() { + StringBuilder sb = new StringBuilder(); + + return sb.append("endpoint address :") + .append(endpoint.getAddress()) + .append("endpoint user port: ") + .append(endpoint.getUserPort()).toString(); + } Review comment: check if field is present or not before accessing it. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
