sohami commented on a change in pull request #1762: [DRILL-7191 / DRILL-7026]: RM state blob persistence in Zookeeper and Integration of Distributed queue configuration with Planner URL: https://github.com/apache/drill/pull/1762#discussion_r279984843
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/planner/fragment/MemoryCalculator.java ########## @@ -46,35 +47,37 @@ private final PlanningSet planningSet; // List of all the buffered operators and their memory requirement per drillbit. - private final Map<DrillbitEndpoint, List<Pair<PhysicalOperator, Long>>> bufferedOperators; + private final Map<DrillNode, List<Pair<PhysicalOperator, Long>>> bufferedOperators; private final QueryContext queryContext; + private final long MINIMUM_MEMORY_FOR_BUFFER_OPERS; Review comment: upper case variable name should be used only for constants, please change it to lower case. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
