HanumathRao commented on a change in pull request #1762: [DRILL-7191 /
DRILL-7026]: RM state blob persistence in Zookeeper and Integration of
Distributed queue configuration with Planner
URL: https://github.com/apache/drill/pull/1762#discussion_r283471493
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/coord/zk/ZookeeperClient.java
##########
@@ -227,13 +230,33 @@ public void create(final String path) {
final String target = PathUtils.join(root, path);
try {
- curator.create().withMode(mode).forPath(target);
+
curator.create().creatingParentsIfNeeded().withMode(mode).forPath(target);
getCache().rebuildNode(target);
} catch (final Exception e) {
throw new DrillRuntimeException("unable to put ", e);
}
}
+ public void createAsTransaction(List<String> paths) {
+ Preconditions.checkNotNull(paths, "no paths provided to create");
Review comment:
Is it also better to check for empty list of paths? Also it might be good to
add a comment for this function.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
