HanumathRao commented on a change in pull request #1762: [DRILL-7191 / DRILL-7026]: RM state blob persistence in Zookeeper and Integration of Distributed queue configuration with Planner URL: https://github.com/apache/drill/pull/1762#discussion_r283490423
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/resourcemgr/rmblobmgr/RMConsistentBlobStoreManager.java ########## @@ -0,0 +1,354 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.resourcemgr.rmblobmgr; + +import avro.shaded.com.google.common.annotations.VisibleForTesting; +import com.fasterxml.jackson.core.JsonGenerator; +import com.fasterxml.jackson.core.JsonParser; +import com.fasterxml.jackson.databind.ObjectMapper; +import com.fasterxml.jackson.databind.SerializationFeature; +import com.fasterxml.jackson.databind.module.SimpleModule; +import org.apache.curator.framework.recipes.locks.InterProcessMutex; +import org.apache.drill.common.scanner.persistence.ScanResult; +import org.apache.drill.exec.coord.zk.ZKClusterCoordinator; +import org.apache.drill.exec.exception.StoreException; +import org.apache.drill.exec.resourcemgr.NodeResources; +import org.apache.drill.exec.resourcemgr.NodeResources.NodeResourcesDe; +import org.apache.drill.exec.resourcemgr.config.QueryQueueConfig; +import org.apache.drill.exec.resourcemgr.rmblobmgr.exception.LeaderChangeException; +import org.apache.drill.exec.resourcemgr.rmblobmgr.exception.RMBlobUpdateException; +import org.apache.drill.exec.resourcemgr.rmblobmgr.exception.ResourceUnavailableException; +import org.apache.drill.exec.resourcemgr.rmblobmgr.rmblob.ClusterStateBlob; +import org.apache.drill.exec.resourcemgr.rmblobmgr.rmblob.ForemanQueueUsageBlob; +import org.apache.drill.exec.resourcemgr.rmblobmgr.rmblob.ForemanResourceUsage; +import org.apache.drill.exec.resourcemgr.rmblobmgr.rmblob.ForemanResourceUsage.ForemanResourceUsageDe; +import org.apache.drill.exec.resourcemgr.rmblobmgr.rmblob.QueueLeadershipBlob; +import org.apache.drill.exec.resourcemgr.rmblobmgr.rmblob.RMStateBlob; +import org.apache.drill.exec.server.DrillbitContext; +import org.apache.drill.exec.store.sys.PersistentStoreConfig; +import org.apache.drill.exec.store.sys.store.ZookeeperTransactionalPersistenceStore; + +import java.util.ArrayList; +import java.util.Collection; +import java.util.HashMap; +import java.util.Iterator; +import java.util.List; +import java.util.Map; +import java.util.stream.Collectors; + +/** + * RM state blobs manager which does all the update to the blobs under a global lock and in transactional manner. + * Since the blobs are updated by multiple Drillbit at same time to maintain the strongly consistent information in + * these blobs it uses a global lock shared across all the Drillbits. + */ +public class RMConsistentBlobStoreManager implements RMBlobStoreManager { + private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(RMConsistentBlobStoreManager.class); + + private static final String RM_BLOBS_ROOT = "rm/blobs"; Review comment: do we need to start this path with "/" ? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
