paul-rogers commented on a change in pull request #1789: DRILL-7181: Improve V3
text reader (row set) error messages
URL: https://github.com/apache/drill/pull/1789#discussion_r285405296
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/scan/framework/SchemaNegotiatorImpl.java
##########
@@ -73,6 +76,25 @@ public OperatorContext context() {
return framework.context();
}
+ @Override
+ public RowSetContext parentErrorContext() {
Review comment:
For file scan, we have two levels of context:
* Parent: operator/plugin-level information.
* Child: per-file information.
By having two distinct classes, assembled via composition, we separate these
two concerns.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
