paul-rogers commented on a change in pull request #1789: DRILL-7181: Improve V3 
text reader (row set) error messages
URL: https://github.com/apache/drill/pull/1789#discussion_r285419313
 
 

 ##########
 File path: 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/rowSet/ResultSetLoader.java
 ##########
 @@ -41,6 +42,12 @@
 
   public static final int DEFAULT_ROW_COUNT = 
BaseValueVector.INITIAL_VALUE_ALLOCATION;
 
+  /**
+   * Context for error messages.
+   */
+
+  RowSetContext context();
 
 Review comment:
   Renamed the class. Then, restructured the class to be more generic and moved 
it into common, alongside UserException. Doing so allowed simplifying usage of 
the context.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to