vvysotskyi commented on a change in pull request #1818: DRILL-7200: Update
Calcite to 1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299529279
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/FilterBuilder.java
##########
@@ -262,6 +262,13 @@ public LogicalExpression
visitFunctionHolderExpression(FunctionHolderExpression
}
}
+ // shows whether function is simplified IS FALSE
+ private boolean isIsFalse(FunctionHolderExpression holderExpression, String
funcName) {
Review comment:
Could you please rename this method to something like `isNot`, since
actually, it checks whether specified functions is `NOT`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
