vvysotskyi commented on a change in pull request #1818: DRILL-7200: Update
Calcite to 1.19.0 / 1.20.0
URL: https://github.com/apache/drill/pull/1818#discussion_r299532499
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/planner/common/DrillAggregateRelBase.java
##########
@@ -34,12 +34,17 @@
import java.util.List;
-
/**
* Base class for logical and physical Aggregations implemented in Drill
*/
public abstract class DrillAggregateRelBase extends Aggregate implements
DrillRelNode {
+ public DrillAggregateRelBase(RelOptCluster cluster, RelTraitSet traits,
RelNode child,
+ ImmutableBitSet groupSet, List<ImmutableBitSet>
groupSets, List<AggregateCall> aggCalls) {
+ super(cluster, traits, child, groupSet, groupSets, aggCalls);
+ }
+
+ @Deprecated // Will be removed before Calcite 2.0
Review comment:
Since you have marked this constructor deprecated, it would be good to
remove its usages if it wasn't done.
Also, please update the comment, we can remove this constructor
independently on the Calcite version we use.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
