arina-ielchiieva commented on a change in pull request #1819: DRILL-7313: Use
Hive schema for MaprDB native reader when field was empty
URL: https://github.com/apache/drill/pull/1819#discussion_r299886201
##########
File path: exec/vector/src/main/codegen/templates/ComplexCopier.java
##########
@@ -102,15 +103,15 @@ private static FieldWriter
getMapWriterForReader(FieldReader reader, MapWriter w
return (FieldWriter) writer.<#if name ==
"Int">integer<#else>${uncappedName}</#if>(name);
<#elseif minor.class?contains("VarDecimal")>
case ${name?upper_case}:
- return (FieldWriter) writer.${uncappedName}(name,
reader.getType().getScale(), reader.getType().getPrecision());
+ return (FieldWriter) writer.${uncappedName}(name, type.getScale(),
type.getPrecision());
Review comment:
I think correct order is to have precision + scale. Could you please create
Jira for refactoring?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
