arina-ielchiieva commented on a change in pull request #1819: DRILL-7313: Use
Hive schema for MaprDB native reader when field was empty
URL: https://github.com/apache/drill/pull/1819#discussion_r299879561
##########
File path:
contrib/format-maprdb/src/main/java/org/apache/drill/exec/store/mapr/db/MapRDBSubScan.java
##########
@@ -57,34 +59,37 @@ public MapRDBSubScan(@JacksonInject StoragePluginRegistry
engineRegistry,
@JsonProperty("regionScanSpecList")
List<MapRDBSubScanSpec> regionScanSpecList,
@JsonProperty("columns") List<SchemaPath> columns,
@JsonProperty("maxRecordsToRead") int maxRecordsToRead,
- @JsonProperty("tableType") String tableType) throws
ExecutionSetupException {
+ @JsonProperty("tableType") String tableType,
+ @JsonProperty("schema") TupleSchema schema) throws
ExecutionSetupException {
Review comment:
Ideally we should use `TupleMetadata` instance not conrete implementation,
DRILL-7272 will add such support, could you please add todo with Jira number in
all places where `TupleSchema` is used so it could be easily tracked.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
