paul-rogers edited a comment on issue #1843: DRILL-7350: Move RowSet related classes from test folder URL: https://github.com/apache/drill/pull/1843#issuecomment-521708575 @vvysotskyi, thanks for making this change. It will allow certain other tasks to be much easier. The first observation is that it would be best not to put the RowSet and ResultSetLoader stuff in the same package: they represent two independent systems and our package naming should make that clear. Perhaps 1) Rename the existing physical.rowSet to physical.resultSet. 2) Move the RowSet classes to a new physical.rowSet. The difference, so we're clear, is that RowSet works on a single batch, while the ResultSet works across a stream of batches. If operators, say, want to use the row set stuff to read batches, then we need a ResultSetReader that automagically handles things like schema changes across batches, etc. To be very clear: "row set" -- A collection of rows. Typically called a "batch" in Drill. "result set" -- A collection of rows for an entire query. Typically consists of multiple (related) batches. I used the term "row set" only because the classes would otherwise get lost with all the existing "Batch" classes. And, we don't have a good name for the result set. I borrowed this name from SQL.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
