arina-ielchiieva commented on a change in pull request #1844: DRILL-7326:
Support repeated lists for CTAS parquet format
URL: https://github.com/apache/drill/pull/1844#discussion_r315590567
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetRecordWriter.java
##########
@@ -292,7 +294,15 @@ private Type getType(MaterializedField field) {
}
return new GroupType(dataMode == DataMode.REPEATED ?
Repetition.REPEATED : Repetition.OPTIONAL, field.getName(), types);
case LIST:
- throw new UnsupportedOperationException("Unsupported type " +
minorType);
+ Preconditions.checkArgument(!field.getChildren().isEmpty(),
Review comment:
Is there a case when this check is needed? If occurrence of such situation
is unlikely, it's better to remove it to avoid unnecessary checks during write.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
