arina-ielchiieva commented on a change in pull request #1844: DRILL-7326:
Support repeated lists for CTAS parquet format
URL: https://github.com/apache/drill/pull/1844#discussion_r316137027
##########
File path:
exec/java-exec/src/main/codegen/templates/EventBasedRecordWriter.java
##########
@@ -96,7 +96,7 @@ private void initFieldWriters() throws IOException {
public static abstract class FieldConverter {
protected static final String LIST = "list";
- protected static final String ELEMENT = "element";
+ public static final String ELEMENT = "element";
Review comment:
Just for consistency, since `ELEMENT` is already used outside, others might
be also used with time. You can leave as is, it was just a suggestion. Anyway,
if you leave as is, please order constants according to access modifies: having
protected / public / protected is incorrect order.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
