arina-ielchiieva commented on a change in pull request #1829: DRILL-7096:
Develop vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r317077102
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/vector/complex/FieldIdUtil.java
##########
@@ -196,18 +206,48 @@ public static TypedFieldId getFieldId(ValueVector
vector, int id, SchemaPath exp
return getFieldIdIfMatchesUnion((UnionVector) vector, builder, false,
seg.getChild());
}
} else if (vector instanceof ListVector) {
- ListVector list = (ListVector) vector;
builder.intermediateType(vector.getField().getType());
builder.addId(id);
- return getFieldIdIfMatches(list, builder, true,
expectedPath.getRootSegment().getChild());
- } else
- if (vector instanceof AbstractContainerVector) {
+ return getFieldIdIfMatches(vector, builder, true,
expectedPath.getRootSegment().getChild(), 1);
+ } else if (vector instanceof DictVector) {
+ MajorType vectorType = vector.getField().getType();
+ builder.intermediateType(vectorType);
+ builder.addId(id);
+ if (seg.isLastPath()) {
+ builder.finalType(vectorType);
+ return builder.build();
+ } else {
+ PathSegment child = seg.getChild();
+ builder.remainder(child);
+ return getFieldIdIfMatches(vector, builder, false,
expectedPath.getRootSegment().getChild(), 0);
+ }
+ } else if (vector instanceof AbstractContainerVector) {
// we're looking for a multi path.
- AbstractContainerVector c = (AbstractContainerVector) vector;
builder.intermediateType(vector.getField().getType());
builder.addId(id);
- return getFieldIdIfMatches(c, builder, true,
expectedPath.getRootSegment().getChild());
-
+ return getFieldIdIfMatches(vector, builder, true,
expectedPath.getRootSegment().getChild(), 1);
+ } else if (vector instanceof RepeatedDictVector) {
+ MajorType vectorType = vector.getField().getType();
+ builder.intermediateType(vectorType);
+ builder.addId(id);
+ if (seg.isLastPath()) {
+ builder.finalType(vectorType);
+ return builder.build();
+ } else {
+ PathSegment child = seg.getChild();
+ if (!child.isArray()) {
+ // repeated map is accessed not by index, ignore?
Review comment:
?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
