arina-ielchiieva commented on a change in pull request #1829: DRILL-7096:
Develop vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r317074248
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/parquet/ParquetTableMetadataUtils.java
##########
@@ -516,13 +495,46 @@ private static long convertToDrillDateValue(int
dateValue) {
.build();
SchemaPath columnPath = SchemaPath.getCompoundPath(column.getName());
- TypeProtos.MajorType majorType = columns.get(columnPath);
- if (majorType == null) {
- columns.put(columnPath, columnType);
- } else {
- TypeProtos.MinorType leastRestrictiveType =
TypeCastRules.getLeastRestrictiveType(Arrays.asList(majorType.getMinorType(),
columnType.getMinorType()));
- if (leastRestrictiveType != majorType.getMinorType()) {
- columns.put(columnPath, columnType);
+ putType(columns, columnPath, columnType);
+ }
+ return columns;
+ }
+
+ /**
+ * Returns map of column names with their drill types for every {@code
NameSegment} in {@code SchemaPath}
Review comment:
```suggestion
* Returns map of column names with their Drill types for every {@code
NameSegment} in {@code SchemaPath}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
