vvysotskyi commented on a change in pull request #1829: DRILL-7096: Develop vector for canonical Map<K,V> URL: https://github.com/apache/drill/pull/1829#discussion_r317151040
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/record/TypedFieldId.java ########## @@ -42,6 +45,7 @@ final boolean isHyperReader; final boolean isListVector; final PathSegment remainder; + private final Map<Integer, MajorType> types; Review comment: Could you please add a comment that this field is used to determine that the map is placed at a specific depth. Also, would it be simpler to use `BitSet` instead of `Map<Integer, MajorType>` for these purposes? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
