vvysotskyi commented on a change in pull request #1829: DRILL-7096: Develop
vector for canonical Map<K,V>
URL: https://github.com/apache/drill/pull/1829#discussion_r317152242
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/record/TypedFieldId.java
##########
@@ -110,6 +116,11 @@ public MajorType getIntermediateType() {
return intermediateType;
}
+ public boolean isMap(int depth) {
Review comment:
I'm a little bit confused with namings: somewhere map still means map, but
somewhere it means dict. Should we use dict where possible to avoid confusion
and add corresponding comments in places where map means dict?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
