KazydubB commented on a change in pull request #1869: DRILL-7254: Read Hive union w/o nulls URL: https://github.com/apache/drill/pull/1869#discussion_r333845448
########## File path: exec/vector/src/main/codegen/templates/UnionVector.java ########## @@ -561,6 +562,8 @@ public Object getObject(int index) { return getMap().getAccessor().getObject(index); case MinorType.LIST_VALUE: return getList().getAccessor().getObject(index); + case MinorType.DICT_VALUE: Review comment: Can you also add `case DICT` to `getMember(MinorType)`, please? So that looks something like ``` public ValueVector getMember(MinorType type) { switch (type) { ... case DICT: return getDict(); ... ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services