KazydubB commented on a change in pull request #1869: DRILL-7254: Read Hive 
union w/o nulls
URL: https://github.com/apache/drill/pull/1869#discussion_r332933924
 
 

 ##########
 File path: 
contrib/storage-hive/core/src/main/java/org/apache/drill/exec/store/hive/writers/complex/HiveUnionWriter.java
 ##########
 @@ -0,0 +1,47 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.drill.exec.store.hive.writers.complex;
+
+import org.apache.drill.exec.store.hive.writers.HiveValueWriter;
+import 
org.apache.drill.exec.store.hive.writers.primitive.AbstractSingleValueWriter;
+import org.apache.hadoop.hive.serde2.objectinspector.UnionObjectInspector;
+
+public class HiveUnionWriter implements HiveValueWriter {
+
+  private final HiveValueWriter[] unionFieldWriters;
+
+  private final UnionObjectInspector unionObjectInspector;
+
+  public HiveUnionWriter(HiveValueWriter[] unionFieldWriters, 
UnionObjectInspector unionObjectInspector) {
+    this.unionFieldWriters = unionFieldWriters;
+    this.unionObjectInspector = unionObjectInspector;
+  }
+
+  @Override
+  public void write(Object value) {
+    int tag = unionObjectInspector.getTag(value);
+    Object field = unionObjectInspector.getField(value);
+    if (field == null) {
+      if (!(unionFieldWriters[tag] instanceof AbstractSingleValueWriter)) {
+        throw new UnsupportedOperationException("Null is not supported in Hive 
union for complex types!");
+      }
 
 Review comment:
   Why skipping of primitive values is OK here? Similar `HiveValueWriter`s 
(`HiveListWriter`, `HiveStructWriter` and `HiveMapWriter`) don't yet support 
nulls and throw `UnsupportedOperationException` for both primitive and complex 
values. 
   While this writer does not support null values, maybe it is better to throw 
the `Exception` too?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to