paul-rogers commented on a change in pull request #1870: DRILL-7359: Add support for DICT type in RowSet Framework URL: https://github.com/apache/drill/pull/1870#discussion_r334287471
########## File path: exec/vector/src/main/java/org/apache/drill/exec/record/metadata/DictBuilder.java ########## @@ -0,0 +1,198 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.record.metadata; + +import org.apache.drill.common.types.TypeProtos; +import org.apache.drill.exec.record.MaterializedField; +import org.apache.drill.exec.vector.complex.DictVector; + +public class DictBuilder implements SchemaContainer { + + private final SchemaContainer parent; + private final TupleBuilder tupleBuilder = new TupleBuilder(); + private final String memberName; + private final TypeProtos.DataMode mode; + + public DictBuilder(String memberName, TypeProtos.DataMode mode) { + this(null, memberName, mode); + } + + public DictBuilder(SchemaContainer parent, String memberName, TypeProtos.DataMode mode) { + this.parent = parent; + this.memberName = memberName; + this.mode = mode; + } + + @Override + public void addColumn(ColumnMetadata column) { Review comment: If we agree DICT is DICT<KEY_TYPE, VALUE_TYPE> then we might want the building of a DICT to be something like: ``` TupleMetadata = new SchemaBuilder() .addDict("myDict") .key(MinorType.VARCHAR) .valueArray(MinorType.DOUBLE) .resumeSchema() ... ``` That is, we need to add one key. Can keys only be scalars? Only non-nullable? If so, then the single `key()` method is all that is needed. This returns the same builder. Can the value be of any type? Then we need the full set of type builders: scalar, array, map and so on. The current form does not make this clear: what does it mean to add a column? This isn't a map... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
