paul-rogers commented on a change in pull request #1870: DRILL-7359: Add
support for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r347114952
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/resultSet/model/single/BuildVectorsFromMetadata.java
##########
@@ -69,7 +71,11 @@ public VectorContainer build(TupleMetadata schema) {
private ValueVector buildVector(ColumnMetadata metadata) {
switch (metadata.structureType()) {
case TUPLE:
- return buildMap(metadata);
+ if (!metadata.isDict()) {
Review comment:
This can be simplified a bit. A Dict should not be a tuple; we should define
a new structure type to indicate that this is a DICT, not a Tuple that happens
to act like a DICT.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
