paul-rogers commented on a change in pull request #1878: DRILL-7414: EVF
incorrectly sets buffer writer index after rollover
URL: https://github.com/apache/drill/pull/1878#discussion_r337311938
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/resultSet/impl/TestResultSetLoaderOverflow.java
##########
@@ -59,55 +61,64 @@
@Test
public void testVectorSizeLimit() {
- TupleMetadata schema = new SchemaBuilder()
+ final TupleMetadata schema = new SchemaBuilder()
Review comment:
Sorry, too much functional programming with Scala in my "real job"; have
gotten used to marking variables 'val` rather than `var`. `final` is the Java
equivalent. But, since Drill does not normally use this convention, removed the
unneeded `final` keywords.
You are right; if there is a performance benefit, the compiler will figure
out that the variable is never modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
