paul-rogers commented on a change in pull request #1878: DRILL-7414: EVF
incorrectly sets buffer writer index after rollover
URL: https://github.com/apache/drill/pull/1878#discussion_r337312721
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/writer/OffsetVectorWriterImpl.java
##########
@@ -290,7 +290,7 @@ public void preRollover() {
// rows. But, this being an offset vector, we add one to account
// for the extra 0 value at the start.
- setValueCount(vectorIndex.rowStartIndex() + 1);
+ setValueCount(vectorIndex.rowStartIndex());
Review comment:
Updated the comment as it was too subtle. The row start index is already at
the proper index, it points past the last valid value (it points to where we'd
add the next value, if we had one.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
