paul-rogers commented on a change in pull request #1879: DRILL-5674: Support
ZIP compression
URL: https://github.com/apache/drill/pull/1879#discussion_r337322883
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/pcapng/PcapngFormatPlugin.java
##########
@@ -47,7 +47,7 @@ public PcapngFormatPlugin(String name, DrillbitContext
context, Configuration fs
public PcapngFormatPlugin(String name, DrillbitContext context,
Configuration fsConf, StoragePluginConfig config, PcapngFormatConfig
formatPluginConfig) {
super(name, context, fsConf, config, formatPluginConfig, true,
- false, true, false,
+ false, true, true,
Review comment:
Isn't the middle `true` wrong? It is for `blockSplittable`. That means we'll
start reading at an arbitrary block boundary. Since this is a binary format, it
is not clear that we can scan forward to the beginning of the next record as
can be done in Sequence File and (restricted) CSV.
Also, if the file is zip-encoded, then it is never block splittable since
Zip files cannot be read at an arbitrary offset.
This creates an issue: the block-splittable attribute right now is a
constant. But, if any file is zip-encoded, then it is never block splittable.
Any way to handle this fact?
And, any way to test this behaviour?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
