paul-rogers commented on a change in pull request #1879: DRILL-5674: Support
ZIP compression
URL: https://github.com/apache/drill/pull/1879#discussion_r337321551
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/store/dfs/FileSystemPlugin.java
##########
@@ -57,7 +61,9 @@
*/
public class FileSystemPlugin extends AbstractStoragePlugin {
- private static final org.slf4j.Logger logger =
org.slf4j.LoggerFactory.getLogger(FileSystemPlugin.class);
+ private static final Logger logger =
LoggerFactory.getLogger(FileSystemPlugin.class);
+
+ private static final List<String> BUILT_IN_CODECS =
Collections.singletonList(ZipCodec.class.getCanonicalName());
Review comment:
Are no other codecs provided "out of the box"? For others, I need to provide
a jar and set a config option? Or, should we move the other built-in ones here
and out of the config file?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
