vvysotskyi commented on a change in pull request #1895: DRILL-6540: Upgrade to 
HADOOP-3.x libraries
URL: https://github.com/apache/drill/pull/1895#discussion_r344270617
 
 

 ##########
 File path: 
exec/jdbc-all/src/test/java/org/apache/drill/jdbc/DrillbitClassLoader.java
 ##########
 @@ -61,21 +58,21 @@ public DrillbitClassLoader() {
    *
    * Taken from Apache Harmony
 
 Review comment:
   If we update this method, perhaps this comment should be also updated. But I 
have a question, why not to use `String.split` instead of this method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to