vvysotskyi commented on a change in pull request #1895: DRILL-6540: Upgrade to
HADOOP-3.x libraries
URL: https://github.com/apache/drill/pull/1895#discussion_r344265278
##########
File path:
exec/java-exec/src/test/java/org/apache/drill/exec/physical/unit/TestOutputBatchSize.java
##########
@@ -328,7 +327,7 @@ public void testProjectVariableWidthImpl(boolean transfer,
int columnCount, Stri
expr[i * 2] = "lower(" + baselineColumns[i] + ")";
expr[i * 2 + 1] = baselineColumns[i];
}
- baselineValues[i] = (transfer ? testString :
Strings.lowerCase(testString));
+ baselineValues[i] = (transfer ? testString : testString.toLowerCase());
Review comment:
`Strings.lowerCase()` returned null if string was null, but this code will
throw NPE...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
