KazydubB commented on a change in pull request #1870: DRILL-7359: Add support
for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r346399315
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/MapBuilder.java
##########
@@ -144,6 +144,14 @@ public RepeatedListBuilder addRepeatedList(String name) {
return tupleBuilder.addRepeatedList(this, name);
}
+ public DictBuilder addDict(String name) {
+ return tupleBuilder.addDict(this, name);
+ }
Review comment:
Good point. Yes, `value` can be nullable (added explicit comment to
`DictVector`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
