KazydubB commented on a change in pull request #1870: DRILL-7359: Add support
for DICT type in RowSet Framework
URL: https://github.com/apache/drill/pull/1870#discussion_r346400409
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/record/metadata/MetadataUtils.java
##########
@@ -205,4 +205,10 @@ private static ColumnMetadata newDecimal(String name,
MinorType type, DataMode m
return new PrimitiveColumnMetadata(field);
}
+ private static boolean isScalar(MinorType type) {
+ return type != MinorType.MAP
+ && type != MinorType.UNION
+ && type != MinorType.LIST
+ && type != MinorType.DICT;
+ }
Review comment:
Yeah, much negation... Changed the body of the method - didn't want to
introduce the new `isComplex()`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
