ihuzenko commented on a change in pull request #1899: DRILL-7445: Create batch
copier based on result set framework
URL: https://github.com/apache/drill/pull/1899#discussion_r347259525
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/protocol/VectorContainerAccessor.java
##########
@@ -22,41 +22,83 @@
import org.apache.drill.common.expression.SchemaPath;
import org.apache.drill.exec.record.BatchSchema;
+import org.apache.drill.exec.record.RecordBatch;
import org.apache.drill.exec.record.TypedFieldId;
import org.apache.drill.exec.record.VectorContainer;
import org.apache.drill.exec.record.VectorWrapper;
import org.apache.drill.exec.record.WritableBatch;
import org.apache.drill.exec.record.selection.SelectionVector2;
import org.apache.drill.exec.record.selection.SelectionVector4;
+import org.apache.drill.shaded.guava.com.google.common.base.Preconditions;
public class VectorContainerAccessor implements BatchAccessor {
- public static class ContainerAndSv2Accessor extends VectorContainerAccessor {
+ public static class ExtendedContainerAccessor extends
VectorContainerAccessor {
Review comment:
Please extract the class to separate file and provide javadoc. Also I know
it's hard but it would be cool to provide more meaningful name for the class.
Maybe something like, ```ExternalSelectionVectorsContainerAccessor```. Also if
batch can contain only either sv2 or sv4 maybe it would be better to have 2
separate classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
