ihuzenko commented on a change in pull request #1899: DRILL-7445: Create batch
copier based on result set framework
URL: https://github.com/apache/drill/pull/1899#discussion_r347383123
##########
File path:
exec/vector/src/main/java/org/apache/drill/exec/vector/accessor/convert/AbstractWriteConverter.java
##########
@@ -143,4 +144,9 @@ public void setTime(LocalTime value) {
public void setTimestamp(Instant value) {
baseWriter.setTimestamp(value);
}
+
+ @Override
+ public void copy(ColumnReader from) {
+ throw new UnsupportedOperationException("Cannot copy values through a type
converter");
Review comment:
If type converters shouldn't support copy then maybe makes sense to mark the
method as final here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
