arjuntheprogrammer commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-556010994 > Hello @arjuntheprogrammer , overall the changes looks good. Please fix failing unit test. > > > TestMetadataProvider.tablesWithSystemTableFilter > > And add two another test methods to cover your fix in IT tests: > > > TestJdbcPluginWithH2IT.java > > TestJdbcPluginWithMySQLIT.java Hi @ihuzenko , thanks for reviewing the pull request. Can you please guide me what type of tests are supposed to be written in these files: TestJdbcPluginWithH2IT.java TestJdbcPluginWithMySQLIT.java Thanks.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
