arjuntheprogrammer commented on issue #1904: DRILL-5844: Incorrect values of TABLE_TYPE returned from method DatabaseMetaData.getTables of JDBC API URL: https://github.com/apache/drill/pull/1904#issuecomment-556054184 > Hi @arjuntheprogrammer , there are a lot of possible options how to check your fix. One simplest example for **TestJdbcPluginWithH2IT.java** is : > > ```java > @Test > public void testJdbcTableTypes() throws Exception { > String query = "select distinct table_type from information_schema.`tables` " + > "where table_schema like 'h2%'"; > testBuilder() > .sqlQuery(query) > .unOrdered() > .baselineColumns("table_type") > .baselineValuesForSingleColumn("SYSTEM TABLE", "TABLE") > .go(); > } > ``` > > similar test could be added to **TestJdbcPluginWithMySQLIT.java**, you'll only need to change where condition to `mysql%` and update expected results. @ihuzenko - I have written the test function in both of the files, and build and test on Travis CI also passed. Please let me know if this issue requires any other changes. Thanks for your help.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
