agozhiy commented on a change in pull request #1910: DRILL-7393: Revisit Drill
tests to ensure that patching is executed b…
URL: https://github.com/apache/drill/pull/1910#discussion_r352360970
##########
File path: common/src/test/java/org/apache/drill/test/BaseTest.java
##########
@@ -15,24 +15,25 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.drill.exec.expr;
+package org.apache.drill.test;
-import org.apache.drill.BaseTestQuery;
-import org.apache.drill.common.util.TestTools;
-import org.junit.Test;
+import org.apache.drill.common.util.GuavaPatcher;
+import org.apache.drill.common.util.ProtobufPatcher;
-public class TestPrune extends BaseTestQuery {
+public class BaseTest {
- String MULTILEVEL = TestTools.getWorkingPath() +
"/../java-exec/src/test/resources/multilevel";
-
- @Test
- public void pruneCompound() throws Exception {
- test(String.format("select * from dfs.`%s/csv` where x is null and dir1 in
('Q1', 'Q2')", MULTILEVEL));
- }
-
- @Test
- public void pruneSimple() throws Exception {
- test(String.format("select * from dfs.`%s/csv` where dir1 in ('Q1',
'Q2')", MULTILEVEL));
+ static {
+ /*
+ * HBase and MapR-DB clients use older version of protobuf,
+ * and override some methods that became final in recent versions.
+ * This code removes these final modifiers.
Review comment:
We're doing patching both in tests and in production (see Drillbit class).
This is actually quite extensive topic. We already have shaded Guava that is
used by Drill. The problem is: some of libraries we're using have transitive
dependencies to different Guava versions. In total we have 3 or 4 versions we
should make friends with. So shading is not the way. I guess we can do some
playing with classloaders, but it'll be tricky and additionally we'll have
bloated jars.
As for your last paragraph, this would definitely be great if every library
had the same dependencies versions or if Guava was fully backward compatible...
Sadly, there is nothing we can do on this account.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
