agozhiy commented on a change in pull request #1910: DRILL-7393: Revisit Drill
tests to ensure that patching is executed b…
URL: https://github.com/apache/drill/pull/1910#discussion_r352361580
##########
File path: common/src/test/java/org/apache/drill/test/BaseTest.java
##########
@@ -15,24 +15,25 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-package org.apache.drill.exec.expr;
+package org.apache.drill.test;
-import org.apache.drill.BaseTestQuery;
-import org.apache.drill.common.util.TestTools;
-import org.junit.Test;
+import org.apache.drill.common.util.GuavaPatcher;
+import org.apache.drill.common.util.ProtobufPatcher;
-public class TestPrune extends BaseTestQuery {
+public class BaseTest {
Review comment:
The original problem was caused by tests that didn't require patching, they
just loaded a Guava class needed to be patched for someone else, an there is no
way we can patch a class that was already loaded. Considering this we should
apply patching as early as possible.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
