vvysotskyi commented on a change in pull request #1923: DRILL-7479: Partial
fixes for metadata parameterized type issues
URL: https://github.com/apache/drill/pull/1923#discussion_r356601735
##########
File path:
metastore/metastore-api/src/main/java/org/apache/drill/metastore/util/TableMetadataUtils.java
##########
@@ -46,21 +46,24 @@
* @param type type of the column
* @return {@link Comparator} instance
*/
- public static Comparator getComparator(TypeProtos.MinorType type) {
+ @SuppressWarnings("unchecked")
+ public static <T> Comparator<T> getComparator(TypeProtos.MinorType type) {
switch (type) {
case INTERVALDAY:
case INTERVAL:
case INTERVALYEAR:
- return
Comparator.nullsFirst(UnsignedBytes.lexicographicalComparator());
+ return (Comparator<T>) (Comparator<?>)
Review comment:
```suggestion
return (Comparator<?>)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
