vvysotskyi commented on a change in pull request #1923: DRILL-7479: Partial 
fixes for metadata parameterized type issues
URL: https://github.com/apache/drill/pull/1923#discussion_r357692806
 
 

 ##########
 File path: 
metastore/metastore-api/src/main/java/org/apache/drill/metastore/components/tables/BasicTablesTransformer.java
 ##########
 @@ -99,6 +99,9 @@ public static MetadataHolder all(List<TableMetadataUnit> 
units) {
         case PARTITION:
           
partitions.add(PartitionMetadata.builder().metadataUnit(unit).build());
           break;
+        default:
+          // Throw an error?
 
 Review comment:
   Please either throw an error here or remove this comment. But it is 
impossible to obtain a non-listed type here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to