paul-rogers commented on a change in pull request #1923: DRILL-7479: Partial
fixes for metadata parameterized type issues
URL: https://github.com/apache/drill/pull/1923#discussion_r358404539
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/expr/ComparisonPredicate.java
##########
@@ -88,11 +88,11 @@ private ComparisonPredicate(LogicalExpression left,
@Override
@SuppressWarnings("unchecked")
public RowsMatch matches(StatisticsProvider<C> evaluator) {
- ColumnStatistics leftStat = left.accept(evaluator, null);
+ ColumnStatistics<BigInteger> leftStat = (ColumnStatistics<BigInteger>)
left.accept(evaluator, null);
Review comment:
Hacked up a solution, but the result is pretty ugly. Feel free to suggest
additional improvements. And the strange casting required is yet another "code
smell" that suggests we need to do a few adjustments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
