ihuzenko commented on a change in pull request #1929: DRILL-6832: Remove the
old "unmanaged" external sort
URL: https://github.com/apache/drill/pull/1929#discussion_r360516350
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/MSorter.java
##########
@@ -24,11 +24,15 @@
import org.apache.drill.exec.record.VectorContainer;
import org.apache.drill.exec.record.selection.SelectionVector4;
-// TODO: Doc.: What's an MSorter? A sorter for merge join? something else?
-// (What's the "M" part? Actually, rename interface to clearer.
+/**
+ * In-memory sorter. Takes a list of batches as input, produces a selection
+ * vector 4, with sorted results, as output.
+ */
+
public interface MSorter {
- public void setup(FragmentContext context, BufferAllocator allocator,
SelectionVector4 vector4, VectorContainer hyperBatch) throws
SchemaChangeException;
- public void sort(VectorContainer container);
+ public void setup(FragmentContext context, BufferAllocator allocator,
SelectionVector4 vector4,
Review comment:
Please remove redundant ```public``` and ```static``` modifiers and move
constant ```TEMPLATE_DEFINITION``` to top, above methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
