ihuzenko commented on a change in pull request #1929: DRILL-6832: Remove the
old "unmanaged" external sort
URL: https://github.com/apache/drill/pull/1929#discussion_r360517824
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/xsort/PriorityQueueCopier.java
##########
@@ -23,14 +23,10 @@
import org.apache.drill.exec.compile.TemplateClassDefinition;
import org.apache.drill.exec.exception.SchemaChangeException;
import org.apache.drill.exec.memory.BufferAllocator;
-import org.apache.drill.exec.ops.FragmentContext;
import org.apache.drill.exec.record.VectorAccessible;
public interface PriorityQueueCopier extends AutoCloseable {
- public static final long INITIAL_ALLOCATION = 10000000;
- public static final long MAX_ALLOCATION = 20000000;
-
- public void setup(FragmentContext context, BufferAllocator allocator,
VectorAccessible hyperBatch,
+ public void setup(BufferAllocator allocator, VectorAccessible hyperBatch,
Review comment:
please remove redundant ```public```, ```final```, ```abstract``` modifiers
in the interface and move constant above methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
