[GitHub] [drill] vvysotskyi commented on a change in pull request #1945: DRILL-7502: Invalid codegen for typeof() with UNION

[GitBox]

vvysotskyi commented on a change in pull request #1945: DRILL-7502: Invalid 
codegen for typeof() with UNION
URL: https://github.com/apache/drill/pull/1945#discussion_r363090485
 
 

 ##########
 File path: exec/java-exec/src/main/codegen/templates/UnionFunctions.java
 ##########
 @@ -43,15 +43,15 @@
  * Additional functions can be found in the class UnionFunctions
  */
 public class GUnionFunctions {
-
   <#list vv.types as type><#list type.minor as minor><#assign name = 
minor.class?cap_first />
   <#assign fields = minor.fields!type.fields />
   <#assign uncappedName = name?uncap_first/>
 
   <#if !minor.class?starts_with("Decimal")>
-
-  @SuppressWarnings("unused")
-  @FunctionTemplate(name = "IS_${name?upper_case}", scope = 
FunctionTemplate.FunctionScope.SIMPLE, nulls=NullHandling.INTERNAL)
+  @FunctionTemplate(
+      name = "IS_${name?upper_case}",
+      scope = FunctionTemplate.FunctionScope.SIMPLE,
+      nulls=NullHandling.INTERNAL)
 
 Review comment:
   ```suggestion
         nulls = NullHandling.INTERNAL)
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services