vvysotskyi commented on a change in pull request #1945: DRILL-7502: Invalid
codegen for typeof() with UNION
URL: https://github.com/apache/drill/pull/1945#discussion_r363377148
##########
File path:
logical/src/main/java/org/apache/drill/common/expression/FunctionHolderExpression.java
##########
@@ -98,4 +105,20 @@ public FieldReference getFieldReference() {
public void setFieldReference(FieldReference fieldReference) {
this.fieldReference = fieldReference;
}
+
+ @Override
+ public String toString() {
+ StringBuilder buf = new StringBuilder()
+ .append("[").append(getClass().getSimpleName())
Review comment:
Please separate somehow separate `getClass().getSimpleName()` and `nameUsed`
in resulting string.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
