vvysotskyi commented on a change in pull request #1914: DRILL-7458: Base framework for storage plugins URL: https://github.com/apache/drill/pull/1914#discussion_r369720302
########## File path: exec/java-exec/src/test/java/org/apache/drill/exec/store/base/TestFilterPushDown.java ########## @@ -0,0 +1,264 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.drill.exec.store.base; + +import org.apache.drill.test.ClusterFixtureBuilder; +import org.apache.drill.test.ClusterTest; +import org.junit.BeforeClass; +import org.junit.Ignore; +import org.junit.Test; + +/** + * Tests for the Filter push-down helper classes as part of the + * "Base" storage plugin to be used for add-on plugins. Uses a + * "test mule" ("Dummy") plug-in which goes through the paces of + * planning push down, but then glosses over the details at run time. + * The focus here are plans: the tests plan a query then compare the + * actual plan against and expected ("golden") plan. + */ +public class TestFilterPushDown extends ClusterTest { + + private static final String BASE_SQL = "SELECT a, b FROM dummy.myTable"; + private static final String BASE_WHERE = BASE_SQL + " WHERE "; + private static final PlanVerifier verifier = new PlanVerifier("/store/base/"); + + // Uncomment the next line to save failing plans to /tmp + // static { verifier.saveResults = true; } + + @BeforeClass + public static void setup() throws Exception { + ClusterFixtureBuilder builder = new ClusterFixtureBuilder(dirTestWatcher); + startCluster(builder); + + DummyStoragePluginConfig config = + new DummyStoragePluginConfig(true, true, false); + cluster.defineStoragePlugin("dummy", config); + } + + //------------------------------------------------- + // Unsupported filter push-down cases + + // No predicates + + @Test + public void testNoPushDown() throws Exception + { Review comment: Please move brace to the same line ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
