ihuzenko commented on a change in pull request #1975: DRILL-7576: Fail fast for
operator errors
URL: https://github.com/apache/drill/pull/1975#discussion_r376926556
##########
File path:
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/TopN/PriorityQueueTemplate.java
##########
@@ -142,11 +143,7 @@ public void add(RecordBatchData batch) throws
SchemaChangeException{
public void generate() {
Stopwatch watch = Stopwatch.createStarted();
final DrillBuf drillBuf = allocator.buffer(4 * queueSize);
- try {
- finalSv4 = new SelectionVector4(drillBuf, queueSize, 4000);
- } catch (SchemaChangeException e) {
- throw AbstractRecordBatch.schemaChangeException(e, "Priority Queue",
logger);
- }
+ finalSv4 = new SelectionVector4(drillBuf, queueSize, 4000);
Review comment:
please convert magic number to constant.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
