ihuzenko commented on a change in pull request #1975: DRILL-7576: Fail fast for operator errors URL: https://github.com/apache/drill/pull/1975#discussion_r376947666
########## File path: exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/aggregate/SpilledRecordBatch.java ########## @@ -163,11 +162,12 @@ public IterOutcome next() { container = vas.get(); } } catch (IOException e) { - lastOutcome = IterOutcome.STOP; - throw UserException.dataReadError(e).addContext("Failed reading from a spill file").build(logger); + throw UserException.dataReadError(e) + .addContext("Failed reading from a spill file") + .build(logger); } catch (Exception e) { - lastOutcome = IterOutcome.STOP; - throw e; + // TODO: Catch the error closer to the cause and create a better error message. Review comment: can we avoid adding new todos? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services